ASM Community

Hi i want to get in a button a icon.

What i have to do ? - It is easy to realize ? - Perhaps its only a question of an resource option...

Unfortunetely the rc.exe doesn't know the keyword "BS_BITMAP".

To set the Icon, I tryed this:
add eax,offset BUTTONIMAGE
mov eax,
INVOKE SendDlgItemMessage, hDlg, IDC_BUTTON3,BM_SETIMAGE, BUTTONIMAGE, EAX

Who to eliminate the resourcen error ?

Hi, first i tryed to include the resource file from C++.
But now it works !

But the icon isnt visible :mad:

BUTTONIMAGE EQU ....
hMyButton DWORD ?
... == INITDIALOG
mov eax,hDlg
mov hDlg,eax
invoke GetDlgItem,hDlg, BUTTONIMAGE
mov hMyButton,eax
invoke SendMessage, hMyButton, BM_SETIMAGE, IMAGE_ICON, BUTTONIMAGE

but this doesnt work.

:( :(

hmm, it still doesnt work - im very sorry !

hICON DWORD ?
hMyButton DWORD ?
..EQU ...
..EQU ...

.IF uMsg == INITDIALOG
mov eax,hDlg
mov hDlg,eax
invoke GetDlgItem,hDlg, IDC_BUTTON3
mov hMyButton,eax
invoke LoadImage, hDlg, BUTTONIMAGE, IMAGE_ICON, 16, 16, NULL
mov hICON,eax
INVOKE SendMessage, hMyButton, BM_SETIMAGE, IMAGE_ICON, BUTTONIMAGE

nothin happens
:rolleyes: :mad: :( :mad:

P.S. Thanks for yout intensive helping donkey !

hm, its doesnt work ! Although even the icon have 16*16 pixels.

:eek: :eek: :eek: :eek: :eek: :stupid:

Is the Icon in a file or in your resource section ? What is it's ID number and what is the ID number of the button.

Hi Red,

The GetDlgItem function is only there to retrieve the handle to the button so that you can send a message to it. It doesn't do anything else but the job it does is critical. You can alternately use SendDlgItemMessage function to send the message without the button handle. The LoadImage function will retrieve a handle to a bitmap or icon in the resource section of your code, YOU MUST PASS THIS HANDLE TO THE BUTTON, nothing else will do. This is a very simple task that is done every day. In your RC file make sure that the style of the button is set to the image type you want to display on it (BS_BITMAP,BS_ICON) it must be one or the other, both won't work. Then use GetDlgItem to retrieve the handle of the button and LoadImage to retrieve the handle of the Icon or bitmap resource. Once you have these two handles use the BM_SETIMAGE message to place the image on your button. That's all there is to it, nothing difficult.

I think you are having trouble understanding some basic concepts in Win32 programming. I would suggest that you check the example code with MASM32 and maybe get a copy of win32api.hlp. Have you ever done any programming in any language before ? If not get a primer or check some of the following web pages that discuss the basics of Win32 programming and the concepts involved.

http://spiff.tripnet.se/~iczelion/
http://www.eskimo.com/%7Ehtak/win32asm/win32asm.htm
http://webster.cs.ucr.edu/
http://www.madwizard.org/view.php?page=tutorials.contents


Donkey

THIS:
mov eax,hDlg
mov hDlg,eax

Basically does nothing. it moves the value of hDlg into eax and back. The proper way is like this, the value for hDlg is in the first parameter of the call to DialogProc

DialogProc proc uses ebx esi edi hWnd:HWND, uMsg:UINT, wParam:WPARAM, lParam:LPARAM

.IF uMsg == WM_INITDIALOG
mov eax,hWnd
mov hDlg,eax

I posted the following code and you failed to use it at every turn. It works, you keep substituting the wrong values:

hButtonIcon DWORD ?

hDlg DWORD ?

hMyButton DWORD ?



.IF uMsg == INITDIALOG

	mov eax,hWnd

	mov hDlg,eax

	invoke GetDlgItem,hDlg,IDC_BUTTON3

	mov hMyButton,eax

	invoke LoadImage, hInstance, BUTTONIMAGE, IMAGE_ICON, 16, 16, NULL

	mov hButtonIcon,eax

	invoke SendMessage, hMyButton, BM_SETIMAGE, IMAGE_ICON, hButtonIcon

BUTTONIMAGE is the ID number of the icon in the resource file
IDC_BUTTON3 is the ID number of the Button on your dialog
All other values are unknown and not important at compile time

I have now wasted about 10 posts on a three line thing that is simple to do. You have to read about the API and maybe some tutorials on basic programming. I will unfortunely have to stop answering until you decide to do some groundwork yourself.

Donkey

Yes ! All right !

The Button3 works, but not the handle.