Hi Donkey & Milos

Once in a while I use MemProof to check RadASM for resource leaks. I found this problem in the addins:

Both addins uses the same proc, UpdateIcon.
This proc uses CloseHandle where DeleteObject should be used.

Could you both update your sources, just in case of future updates.

KetilO
Posted on 2003-07-02 16:40:32 by KetilO
Hi Ketil,

I should have checked for GDI leaks, this should take care of them. Milos is on vacation so I changed ButtonChanger as well.

I made the following changes:
invoke GetSysColor, COLOR_BTNFACE

invoke CreateSolidBrush, eax
push eax
invoke SelectObject, myDC, eax
push eax
push myDC
invoke CreateRectRgn, 0, 0, 16, 16
push eax
invoke PaintRgn, myDC, eax
; call CloseHandle
call DeleteObject
call SelectObject
; call CloseHandle
call DeleteObject
Posted on 2003-07-02 17:41:14 by donkey
I just downloaded MemProof, nice. Thanks Ketil :alright:

Added it to my tools menu > "C:\Program Files\MemProof\MemProof.exe",5
Posted on 2003-07-02 18:43:20 by donkey
Hi donkey

New upload in your post.
ButtonChanger was the old version and the bitmap also needs DeleteObject when RadASM closes.

Agree, MemProof is very nice and handy.

KetilO
Posted on 2003-07-02 19:13:41 by KetilO
I have way too many copies of ButtonChanger :)

I have my original working copy, my original release, Milos' changed version and his new version. Time for a clean up I think.
Posted on 2003-07-02 19:38:36 by donkey