there's more 'interesting' stuff in there :grin:

win2k\private\shell\comctl32\treeview.c
//
// Eudora is a pile of crap.
//
// When they get a NM_DBLCLK notification from a treeview, they say,
// "Oh, I know that treeview allocates its NMHDR from the stack, and
// there's this local variable on Treeview's stack I'm really interested
// in, so I'm going to hard-code an offset from the pnmhdr and read the
// DWORD at that location so I can get at the local variable. I will then
// stop working if this value is zero."
//
// The conversion to UNICODE changed our stack layout enough that they
// end up always getting zero -- it's the NULL parameter which is the
// final argument to CCSendNotify. Since all this stack layout stuff is
// sensitive to how the compiler's optimizer feels today, we create a
// special notify structure Just For Eudora which mimics the stack layout
// they expected to see in Win95.
//



guess bill doesn't write anything anymore (except cheques, i guess)
Posted on 2004-02-13 17:18:57 by Tola

yep that's what some people say. They said the source is well written and commented(esp. on the assembly files).

personally, it's a waste of time to look since I have much better productive things to do.

:wave:


Having looked at the code, I can definitely say it's 100 times better commented than Unix's source code (which I also had at the time). OTOH, that's not to say that reading the code is a cakewalk. The sheer size of the system makes it difficult to understand what's going on anywhere in the system.
Cheers,
Randy Hyde
Posted on 2004-02-13 17:20:10 by rhyde
Heh Tola, that eudora stuff sounds fun - too bad that people have this kind of mentality, reminds me of a few people from this board.

Randy, I guess nobody has a full overview of the entire system, but that you'll focus on only a part of it - and get intimate with that. I guess it should be possible to have a good common win32 api understanding + a nice overview of the kernel (ie, not necessarily knowing everything, but where to look for it). Wouldn't a source browsing database thingy ease the stuff a bit anyway?
Posted on 2004-02-13 18:21:13 by f0dder

Heh Tola, that eudora stuff sounds fun - too bad that people have this kind of mentality, reminds me of a few people from this board.

i wonder why they went through the trouble of fixing that instead of telling the eudora guys to go to hell :confused:
Posted on 2004-02-13 18:35:05 by Tola
me too - supporting something this hacky sucks... and legacy code, especially of the win16 and win9x type, is annoying.

...but I guess it shows that they care about their users?
(Or perhaps just HOW big a can of worms the common control source is ;-))
Posted on 2004-02-13 18:37:38 by f0dder
OK now I see I am not the only one that likes to use F word in their comments :grin:
Posted on 2004-02-13 21:10:02 by Mikky

OK now I see I am not the only one that likes to use F word in their comments :grin:
It is the fully natural response of debugging a plainly stupid error after an insanely long amount of time - I use it quite frequently myself. ;)
Posted on 2004-02-13 23:31:07 by bitRAKE
win2k\private\inet\controls\framewrk\ctlview.cpp
Line 709 - // wow, this sucks.
win2k\private\inet\wininet\ftp\test\multfind\multf
ind.c
Line 29 - printf("Ha! There is no verbose mode, sucker. Try again\n");
win2k\private\shell\browseui\shbrows2.cpp
Line 4839 - // BUGBUG: ALL of this code just sucks. The PMs finally decided that
Line 4843 - // we can get ride of all this crap.
win2k\private\shell\ext\msnspa\proxy.c
Line 395 - // BUGBUG -- Win95 sucks. Close the socket and try again
win2k\private\shell\ext\shimgvw\prevwnd.h
Line 154 - BOOL m_fPrintable; // Stupid printing crap that LarryE wanted
win2k\private\windows\media\avi\drawdib\ddsucks.c
Line 243 - DPF(("** WARNING YOUR DISPLAY DRIVER SUCKS DOING DIBS **"));


Now that we all have seen the windows source code (posted above) arent we all screwed ;)

And isnt Tola doubly screwed as we all know that he for sure has the Windows source and has taken a real hard look at it :grin:
Posted on 2004-02-15 07:03:51 by clippy