ASM Community

i know that there are topics on accelerators, but it seems like i'm doing everything right, and yet my code doesn't work :/

accels	ACCEL <FCONTROL or FVIRTKEY, VK_F12, IDM_TEXTURE>

		ACCEL <FCONTROL, "Z", IDM_UNDO>

		; Create accelerator table

			call	CreateAcceleratorTable, offset accels, 2

			or	eax, eax

			jz	dstrwnd

			mov	[hAccel], eax

align 4		; Message loop

msglp:			mov	esi, offset MessageStruct

			jmp	@@get_msg

align 4

@@msg_loop:		call	TranslateAccelerator, [hwndMain], [hAccel], esi

			or	eax, eax

			jnz	@@get_msg

			call	TranslateMessage, esi

			call	DispatchMessage, esi



@@get_msg:		call	GetMessage, esi, edi, edi, edi

			inc	eax

			jz	dstrwnd

			dec	eax

			jnz	@@msg_loop

it doesn't post any WM_COMMAND when i press CTRL+F12 or CTRL+Z :/

nope, i still dont get any WM_COMMAND. debugging showed that TranslateAccelerators _ALWAYS_ returns 0 regardless of what i press :/

CreateAcceleratorTable succeedes, and TranslateAccelerators fails. strange... :roll:

Afternoon, ti_mo_n.

I don't know which examples you've gotten your info on how to use Accelerators, however I use the following:

Inside the application's *.rc file you have:

#define IDM_FILE_NEW 10001

#define IDM_FILE_OPEN 10002

#define IDM_FILE_SAVE 10003

#define IDM_FILE_SAVEAS 10004

#define IDM_FILE_PRINT 10005

#define IDM_FILE_EXIT 10006



IDAPP ACCELERATORS DISCARDABLE 

{

    VK_ESCAPE,  IDM_FILE_EXIT,       VIRTKEY, NOINVERT

    "N",        IDM_FILE_NEW,        VIRTKEY, CONTROL, NOINVERT

    "O",        IDM_FILE_OPEN,       VIRTKEY, CONTROL, NOINVERT

    "S",        IDM_FILE_SAVE,       VIRTKEY, CONTROL, NOINVERT

}

and you load it by using:

    INVOKE LoadAccelerators, hInst, ADDR szIDATMO

    mov hAccel, eax

where hInst is the Instance Handle supplied via WinMain proc. and

    szIDATMO                    db  "IDAPP",0

    hAccel		dd 0

The Message Pump is simply:

	;===================================

      ; Loop until PostQuitMessage is sent

      ;===================================

	.WHILE TRUE

 		INVOKE GetMessage, ADDR msg, 0,0,0

		.BREAK .IF (!eax)

		INVOKE TranslateAccelerator, hWindow, hAccel, ADDR msg



 		.IF	!eax

		    INVOKE TranslateMessage, ADDR msg

          	INVOKE DispatchMessage, ADDR msg

		.ENDIF

	.ENDW

After that, just handle the message as if they were Menu messages.

Cheers,
Scronty

Then that means that your accelator table is not created correctly in memory if I am not wrong... But I am not so sure since I never used that api before.

Afternoon, Donkey.

align 4

    myAcceleratorKeys myACCEL <FVIRTKEY, 0, VK_ESCAPE, IDM_FILE_EXIT >

                            myACCEL <FCONTROL OR FVIRTKEY,  0, "N", IDM_FILE_NEW  >

                            myACCEL <FCONTROL OR FVIRTKEY,  0, "O", IDM_FILE_OPEN >

                            myACCEL <FCONTROL OR FVIRTKEY,  0, "S", IDM_FILE_SAVE >

works fine.

If the ascii characters didn't work for you then it might've been a data alignment problem or the characters were given as lower-case.

Thanks for the correct definition of the ACCEL structure.

Cheers,
Scronty

yuppie! :) it finally started working! thanks donkey for the structure! :) i can confirm (like donkey said) that it is required to use virtual keys only, because it doesn't work elseway. even if i use '0'-'9' or 'A'-'Z' i need to type (the letters) uppercase and specify the FVIRTKEY flag.

Hi tenkey,

Though I understand what you mean, I think that any structure defintion that depends on the proper alignment switch to "add" a member, not just align the entry point, is wrong. MSDN documents the pad bytes in almost every struct I have seen that uses them except this one. So based on their past behaviour, this defintion is in error. The real pain is that there are not alot of places where you can find this little tidbit for such a useful API if you want user definable accelerator keys and all of the functions return normally, even the count of accels is good when queried.

Afternoon, Steve.

Just modified the ACCEL structure definition in the windows.inc file I have to the one you've supplied, and adjusted my code to:

    myAcceleratorKeys       ACCEL <FVIRTKEY,             VK_ESCAPE,   IDM_FILE_EXIT >

                            ACCEL <FCONTROL or FVIRTKEY, "N",         IDM_FILE_NEW  >

                            ACCEL <FCONTROL or FVIRTKEY, "O",         IDM_FILE_OPEN >

                            ACCEL <FCONTROL or FVIRTKEY, "S",         IDM_FILE_SAVE >

It works fine, however it must be noted that the use of the FVIRTKEY flag is still a must.

Cheers,
Scronty