ASM Community

Hey, once again I'm translating C code to ASM (this is getting boring huh?) and just found out a problem... I have this non null terminated string and I need to null terminate it (bet you didn't see that coming...)...

In C I used something like:

pszFileText = 0;

where dwFileSize is the size of the file, and pszFileText is string that will hold the file's content (once again I bet you didn't see that coming...)

I tried this in Assembly:

invoke lstrcat,pszFileText,0

But it dosen't seem to be working... Actually I don't know if the error is there :P The main problem is: I'm doing a notepad, when you open a file for the first time everything works fine, but at the second time the program just closes. If someone comes and tells me that the error is not there I'll post the full code and you guys can tell me where the error is.

Thanks for your patience.

I'm getting two weird errors on these lines:

Thanks :) It solved one problem, but got me another one... Sometimes the code works fine, sometimes nothing happens (most of the times), the same file that oppened one second ago dosen't open anymore... I'll be posting my code now to see if it helps:

Note: This function isn't mine, it's this guy's (modified a little).

LoadTextFileToEdit proc
    LOCAL hFile:HANDLE, dwFileSize:DWORD, pszFileText:LPSTR, dwRead:DWORD

    invoke CreateFile,addr buffer,GENERIC_READ,FILE_SHARE_READ,NULL,OPEN_EXISTING,0,NULL
    .if eax != INVALID_HANDLE_VALUE
        mov hFile, eax
        invoke GetFileSize, hFile, NULL
        .if eax != 0
            mov dwFileSize, eax
            invoke GlobalAlloc, GPTR, dwFileSize + 1
            .if eax != NULL
                mov pszFileText, eax
                invoke ReadFile, hFile, pszFileText, dwFileSize, addr dwRead, NULL
                .if eax==TRUE
                    mov eax,pszFileText
                    add eax,dwFileSize
                    mov byte ptr, 0
                	invoke SetWindowText, hwndEdit, pszFileText
                .endif
                invoke GlobalFree, pszFileText
            .endif
        .endif
        invoke CloseHandle, hFile
    .endif
    xor eax, eax
    ret
LoadTextFileToEdit endp

Since I'm already here I have two more problems to be solved: I once made a topic about reading binary files, f0dder said I need to use a bin2hex function, and that there was a speed contest of this function, I searched it but never found it, so if someone could tell me where that contest is...

Second: I'm modifying the edit's size each time a WM_SIZE message is sent so that it will cover the whole program's area, it works fine but when resizing it "blinks", you know, turns kinda brown for some miliseconds...

    .elseif uMsg==WM_SIZE
        mov eax,lParam
        mov edx,eax
        shr edx,16
        and eax,0ffffh
        invoke MoveWindow,hwndEdit,0,0,eax,edx,TRUE

I should check for 0xffffffff, but when I do

.if eax != 0xffffffff

I get:


That works aswell, but the window keeps blinking.

Works perfectly :) One problem solved, three to go (shown above).

:) Now there's only one problem, the finding the bin2hex speed contest...

But... More code needs to be checked :) (don't be mad with me), this time the problem is with the SaveTextFileFromEdit function... When you use it a new file is created (as you specified it) but it comes totally empty, nothing in it.

SaveTextFileFromEdit proc FilePath:DWORD
    LOCAL hFile:HANDLE, dwTextLength:DWORD, dwBufferSize:DWORD, dwWritten:DWORD, pszText:LPSTR
    
    invoke CreateFile,FilePath,GENERIC_WRITE,0,NULL,CREATE_ALWAYS,FILE_ATTRIBUTE_NORMAL,NULL
    .if eax != INVALID_HANDLE_VALUE
        mov hFile, eax
        invoke GetWindowTextLength, hwndEdit
        .if eax > 0
            mov dwTextLength, eax
            inc eax
            mov dwBufferSize, eax
            invoke GlobalAlloc, GPTR, dwBufferSize
            .if eax != NULL
                mov pszText, eax
                invoke GetWindowText,hwndEdit, pszText, dwBufferSize
                .if eax==TRUE
                    invoke WriteFile,hFile, pszText, dwTextLength, addr dwWritten, NULL
                .endif
            	invoke GlobalFree, pszText
            .endif
        .endif
        invoke CloseHandle, hFile
    .endif
	xor eax, eax
	ret
SaveTextFileFromEdit endp

And one more really basic question, how do I add a line break to a messagebox? I've tried \n, \n\n, \r\n without any results...

Thanks :)

Oh thanks for the hint, just found where the error was...

The error was that GetWindowText dosn't return TRUE on succes, but the window lenght instead, so just had to change from .if eax == TRUE to .if eax

In case you have the link to that bin2hex speed contest link please post it :)

If you mean you cannot see the new font on the monitor, you then have to select that new font in whatever window or control where it needs to be used. See SelectObject.

If you meant something else, please clarify.

Raymond

A kind word of advice: Whenever you need to use one of the Windows functions, you should inform yourself of its requirements; it will save you many headaches.

The very first line of this one is (bold and underline added):

The SelectObject function selects an object into the specified device context.

Raymond