Hello, for a simple upx gui i like to know how i to get the filename without the extension. im not shure,but i think i have to write a function who look if extension is something like : .exe ,.bmp ,.avi if yes,then delete it. but this will take some time. in delphi i search for the '.' and remove all behind it. can i use this also in asm and how ? sorry,dont know how i can make this. Thank you
Posted on 2001-06-04 02:09:00 by Newbie
i assume that the filename is in a buffer. so you can use lstrlen to get the number of letters in the string. then do something like that:

zeroes db 0,0,0

lea esi,zeroes
lea edi,string
add edi,strlength
sub edi,4
mov ecx,4
rep movsb
this should work. you know that the last 4 chars of the string are ".ext" so you fill this last 4 chars with zeroes. that's all....
Posted on 2001-06-04 04:34:00 by [-alloces-]
You can use the following code :

RemoveExt	PROC	USES EDI ECX, pFilename:DWORD
	mov	edi, pFilename
	mov	ax, '.'
	mov	ecx, MAX_PATH
	repne	scasb                 
	mov	byte ptr , ah
RemoveExt	ENDP
It will replace the first '.' in the file name with a 0. Alloces, You don't need to use rep movsb to copy 4 bytes. You can replace

lea esi,zeroes
lea edi,string
add edi,strlength
sub edi,4
mov ecx,4
rep movsb

mov eax, strlength
mov dword ptr string, 0
But some file extensions are longer than 3 characters (.html for example) This message was edited by karim, on 6/4/2001 6:06:22 AM
Posted on 2001-06-04 05:03:00 by karim
hmm... alloces, what if the extension isn't 3 chars, or the file doesn't have an extension? karim, what if there's another period in the filename? i'd do something like this:

RemoveExt proc uses edi filename:LPSTR
invoke lstrlen, filename
mov ecx, eax
lea edi, 
mov al, '.'
repne scasb
jecxz no_ext
mov byte ptr , 0
RemoveExt endp
that should work, i think. haven't tested it though so don't count on it. :D This message was edited by fresh, on 6/4/2001 6:11:11 AM
Posted on 2001-06-04 06:10:00 by fresh
Another solution :

mov     ecx, MAX_PATH
mov     esi, pString
mov     edi, MAX_PATH+1
mov     bx, '.'
@@ :
mov     al, 
inc     esi
cmp     al, bl
cmove   edi, esi
or      al, al
loopnz  @B
mov     , bh
This way we are sure that the last '.' is replaced with a 0. If there is no '.' in the string, the last character will be replaced with a zero but it's not a problem since the string must end with a zero anyway. This message was edited by karim, on 6/4/2001 6:28:51 PM
Posted on 2001-06-04 07:28:00 by karim
I would use... include shlwapi.inc ... invoke PathRemoveExtension, addr pString
Posted on 2001-06-04 13:27:00 by gfalen
The code doesn't seem to be optimized. It's better to use clean assembly code when you can.
Posted on 2001-06-04 18:04:00 by karim
The DLL code may indeed not be optimal speed - wise, but then again are we really lokking for speed in this case? It seems like there is an undue concern about improving code speed at the expense of code size. In a tight loop (like array processing type code) this would be pertinent. But from my experience most of the time the DLL function calls are the major bottleneck to speed optimization. I tend to try to minimize code size more often for this reason. A judicious amount of hand tweeking for speed is of course a good thing when used at the right places! have fun!
Posted on 2001-06-04 22:07:00 by gfalen
I agree with you. Optimization is complex. There a lot of parameters to take into account (branch target buffer, caching, instruction pairing, stalls, etc.). And your process can be interrupted at any moment by the os. However, it's always better to use your own code. The dll code is longer in the shwapi, so there is no gain in term of size of code.
Posted on 2001-06-05 12:06:00 by karim