ASM Community

smurillo9,

Without proper pd initialization (correct pd.lStructSize, for example) PrintDlgEx() probably fails (E_INVALIDARG status?).

Hello again!
Well checking in some examples (Genesys text editor from the examples), I found what you told, so here is the new code, but it still doesn't work, like the other program, it compiles and executes fine, but my button does nothing  :mad:

.Const

.Data?
hInstance	DD	?

.Data
cnt	DD	0

.Code

Window1Procedure Proc Private hWnd:HWND, uMsg:ULONG, wParam:WPARAM, lParam:LPARAM

	Local pd:PRINTDLG
	.If uMsg == WM_CREATE

	.ElseIf uMsg == WM_COMMAND

			LoWord wParam
			.If Eax == IDC_WINDOW1_PRNT
				HiWord wParam
					.ElseIf Ax == BN_CLICKED

						Mov cnt, 0
        				Mov pd.lStructSize, SizeOf pd
				        Mov Eax, hWnd
				        Mov pd.hwndOwner, Eax
				        Mov Eax, hInstance
				        Mov pd.hInstance, Eax
				        Mov pd.Flags, PD_RETURNDC

						Invoke PrintDlg, Addr pd
						Mov Ax, pd.nToPage
						
				        Mov Eax, pd.Flags
				        Mov Ebx, Eax
				        And Ebx, 000000FFH

				        

					.EndIf

	.ElseIf uMsg == WM_CLOSE
		Invoke IsModal, hWnd
		.If Eax
			Invoke EndModal, hWnd, IDCANCEL
			Return TRUE
		.EndIf
	.EndIf
	Return FALSE

Window1Procedure EndP

but the button in that code doesn't work either...

thanks for your help

hello!

i check for some examples and th only members of the struct initialized are trhe ones i post in this version, compilation and execution runs, but the dialog doesn't apear. iv'e included comctl32, comdlg32 kernel32 shell32 and user32 libs and incs...

other thing is that hDC, HWND flags and struct size don't need to be initialized, but hinstance, an the other uncommented throw errors if they are not!
:sad:

again, thanks for the help you coud give!

.Const

.Data?
hInstance	DD		?
hREd		HWND	?	; Handle

;lStructSize DWord	?
;hwndOwner 	HWND	?
hDevMode	HGLOBAL ?
hDevNames	HGLOBAL	?
;hDC			HDC 	?
;Flags		DWord	?
nFromPage 	Word 	?
nToPage		Word 	?
nMinPage	Word 	?
nMaxPage	Word 	?
nCopies		Word 	?

;lCustData	LPARAM 	?

;lpfnPrintHook	LPPRINTHOOKPROC	?
;lpfnSetupHook	LPSETUPHOOKPROC	?

;lpPrintTemplateName	LPCTSTR 	?
;lpSetupTemplateName	LPCTSTR 	?
;hPrintTemplate		HANDLE 	?
;hSetupTemplate		HANDLE 	?

cr			CHARRANGE	<?>	;Character range

.Data
cnt	DD	0
Sel	DD  0  ; Flags a 'Range' type print job, currently unused

.Code

Window1Procedure Proc Private hWnd:HWND, uMsg:ULONG, wParam:WPARAM, lParam:LPARAM

	Local pd:PRINTDLG
	.If uMsg == WM_CREATE

	.ElseIf uMsg == WM_COMMAND

			LoWord wParam
			.If Eax == IDC_WINDOW1_PRNT
				HiWord wParam
					.ElseIf Ax == BN_CLICKED

						Mov cnt, 0
						Mov Eax, 0
        				Mov pd.lStructSize, SizeOf pd
					

					;-----------------------------------------------------
					; inicializa miembros del struct

				        Mov Eax, hWnd
				        Mov pd.hwndOwner, Eax

				        ;Mov Eax, hInstance
				        Mov pd.hInstance, 0
				        ;Mov Eax, hDevMode
				        Mov pd.hDevMode, NULL
				        Mov pd.hDevNames, NULL
				        Mov pd.hDC, NULL
				        ;Mov Eax, hDevNames

				        ;Mov Ax, nCopies
				        ;Mov pd.nCopies, Ax
				        ;Mov Ax, nFromPage
				        ;Mov pd.nFromPage, Ax
				        ;Mov Ax, nMinPage
				        Mov pd.nMinPage, 1
				        ;Mov Ax, nMaxPage
				        Mov pd.nMaxPage, 100
				        Mov pd.lpPrintTemplateName, NULL

					;-----------------------------------------------------
				        Mov pd.Flags, PD_RETURNDC

						Invoke PrintDlg, Addr pd
						;Mov Ax, pd.nToPage

						;Cmp Eax, FALSE
				        ;Je PrtRet
				        Mov Eax, pd.Flags
				        Mov Ebx, Eax
				        And Ebx, 000000FFH
				        ;Mov Sel, Ebx
				        
;PrtRet:
					.EndIf

	.ElseIf uMsg == WM_CLOSE
		Invoke IsModal, hWnd
		.If Eax
			Invoke EndModal, hWnd, IDCANCEL
			Return TRUE
		.EndIf
	.EndIf
	Return FALSE

Window1Procedure EndP

all codes i've posted are compilable, they are implemented in easy code. the GUI is a simple button named prnt and when is clicked it calls printproc where i initialize the strct and call printdlg

.Const

.Data?
hInstance	DD		?
hREd		HWND	?	; Handle

;lStructSize DWord	?
hwndOwner 	HWND	?
hDevMode	HGLOBAL ?
hDevNames	HGLOBAL	?
;hDC			HDC 	?
;Flags		DWord	?
;nFromPage 	Word 	?
;nToPage		Word 	?
;nMinPage	Word 	?
;nMaxPage	Word 	?
nCopies		Word 	?

;lCustData	LPARAM 	?

;lpfnPrintHook	LPPRINTHOOKPROC	?
;lpfnSetupHook	LPSETUPHOOKPROC	?

;lpPrintTemplateName	LPCTSTR 	?
;lpSetupTemplateName	LPCTSTR 	?
;hPrintTemplate		HANDLE 	?
;hSetupTemplate		HANDLE 	?

.Data

.Code

Window1Procedure Proc Private hWnd:HWND, uMsg:ULONG, wParam:WPARAM, lParam:LPARAM

	.If uMsg == WM_CREATE

	.ElseIf uMsg == WM_COMMAND

		LoWord wParam
		.If Eax == IDC_WINDOW1_PRNT
			HiWord wParam
			.ElseIf Ax == BN_CLICKED

			Call printProc

			.EndIf

	.ElseIf uMsg == WM_CLOSE
		Invoke IsModal, hWnd
		.If Eax
			Invoke EndModal, hWnd, IDCANCEL
			Return TRUE
		.EndIf
	.EndIf
	Return FALSE

Window1Procedure EndP

printProc Proc hWnd:HWND
	Local pd:PRINTDLG

	;Mov cnt, 0
	;Mov Eax, 0
;-----------------------------------------------------
	; inicializa miembros del struct

	Mov pd.lStructSize, SizeOf pd
	Invoke GetModuleHandle, NULL

	Mov Eax, hWnd
	Mov pd.hInstance, Eax
	Mov pd.hwndOwner, HWND_DESKTOP
	Mov pd.Flags, PD_RETURNDC ;Or PD_COLLATE
	Mov pd.hDevMode, NULL
	Mov pd.hDevNames, NULL
	Mov pd.hDC, NULL
;	Mov pd.nMinPage, 1
;	Mov pd.nMaxPage, 100
	Mov pd.lpPrintTemplateName, NULL

	Invoke PrintDlgA, Addr pd
	
	;-----------------------------------------------------

	Ret
printProc EndP

the problem is that the code compiles fine and when i click on execute the window appears, but the button doesn't invoke the print dialog

good news at last, it seems that the printdgl was the problem, but i implemented the invoke with the printdialog and using the 3 parameters instead the lonely addr pd, and it worked fine!

Thanks for your help  :P