ASM Community

hi everyone

somebody know hou to convert this small piece to masm syntax?
i thought it was some sort of struct

typedef enum _PinDirection {
  PINDIR_INPUT,
  PINDIR_OUTPUT
} PIN_DIRECTION;

Kind Regards
jpam

Nah, an enum is just a way to automatically define a series of constants. It starts at 0, and increases each next constant by 1 (and optionally you can force a constant to a value, and it will continue from there).
Basically it says something like this:
PINDIR_INPUT equ 0
PINDIR_OUTPUT equ 1

mybe some more info is needed

c++ code

HRESULT GetUnconnectedPin(
    IBaseFilter *pFilter,   // Pointer to the filter.
    PIN_DIRECTION PinDir,   // Direction of the pin to find.
    IPin **ppPin)           // Receives a pointer to the pin.
{
    *ppPin = 0;
    IEnumPins *pEnum = 0;
    IPin *pPin = 0;
    HRESULT hr = pFilter->EnumPins(&pEnum);
    if (FAILED(hr))
    {
        return hr;
    }
    while (pEnum->Next(1, &pPin, NULL) == S_OK)
    {
        PIN_DIRECTION ThisPinDir;
        pPin->QueryDirection(&ThisPinDir);
        if (ThisPinDir == PinDir)
        {
            IPin *pTmp = 0;
            hr = pPin->ConnectedTo(&pTmp);
            if (SUCCEEDED(hr))  // Already connected, not the pin we want.
            {
                pTmp->Release();
            }
            else  // Unconnected, this is the pin we want.
            {
                pEnum->Release();
                *ppPin = pPin;
                return S_OK;
            }
        }
        pPin->Release();
    }
    pEnum->Release();
    // Did not find a matching pin.
    return E_FAIL;
}

this is a part of the code i have made:

         

_PinDirection STRUCT
   		PINDIR_INPUT equ 0
   		PINDIR_OUTPUT equ 1
	_PinDirection ENDS

	PIN_DIRECTION TYPEDEF _PinDirection

	mov eax,PIN_DIRECTION
	mov ThisPinDir,eax
	
	@@:
		coinvoke pEnum,IEnumMoniker,Next,1,addr pPin,ADDR pcFetched
		cmp eax,0
		jne @F

		coinvoke pPin,IPin,QueryDirection,addr ThisPinDir
		PrintHex eax,"QueryDirection"
		PrintDec ThisPinDir ; show Direction
		
		cmp eax,1
		jne @B
		
		coinvoke pPin,IPin,ConnectedTo,addr ppPin ; CRASH!
		PrintHec eax 	; show result
		PrintDec ppPin 	; do i have a pointer ?
	
	@@:

PrintHex eax,"QueryDirection" gives error code (80004003) Invalid pointer

thanks people for looking at my problem !

i have tried all the possible solutions
but the line; "coinvoke pPin,IPin,QueryDirection,addr ThisPinDir" still crashed
i was wondering if my IPin interface is 100% correct
i added it myself to the Directshow.inc, because it was not included in my version.

sIID_IPin 				TEXTEQU <{056a86891h,00ad4h,011ceh,{0b0h,03ah,000h,020h,0afh,00bh,0a7h,070h}}>

_vtIPin MACRO CastName:REQ
	; IUnknown methods 
	_vtIUnknown CastName
	; IPin methods  
	&CastName&_Connect					comethod3	?
	&CastName&_ReceiveConnection		comethod3	?
	&CastName&_Disconnect				comethod1	?
	&CastName&_ConnectedTo				comethod2	?
	&CastName&_ConnectionMediaType		comethod2	?
	&CastName&_QueryPinInfo				comethod2	?
	&CastName&_QueryDirection			comethod2	?	
	&CastName&_QueryId					comethod2	?
	&CastName&_QueryAccept				comethod2	?
	&CastName&_EnumMediaTypes			comethod2	?
	&CastName&_QueryInternalConnections	comethod3	?
	&CastName&_EndOfStream				comethod1	?
	&CastName&_BeginFlush				comethod1	?
	&CastName&_EndFlush					comethod1	?
	&CastName&_NewSegment				comethod4	?
ENDM

IPin	STRUCT
	_vtIPin	IPin
IPin	ENDS

i hope someone wants to verified my IPin struct

Thanks Homer
Thanks biterider


i corrected the IPin interface, QueryDirection should be the last member
i also made a custom comethod for the NewSegment member
to correct the bytelenght of the interface
it uses 2 qwords and 1 dword

comethodCustomProto      typedef proto :QWORD, :QWORD, :DWORD
comethodCustom	    typedef ptr comethodCustomProto

now the code does not crash anymore :)
but the result in ThisPinDir gives me (looks like) a pointer
shouldn't it be 0 or 1 ?

hi biterider

i don't use IPin::NewSegment :)
i only corrected the member typedef
the HRESULT from IPin::QueryDirection is S_OK

found other solution to grab all frames from video file
can't make that IPin interface working :(

here's a working proc

GrabVideoBitmap proc
	
	LOCAL pBuffer,hBitmap,BitmapSize,hDC,tmpDC,hOLD:dword
	LOCAL MediaType:AM_MEDIA_TYPE
	LOCAL mt:AM_MEDIA_TYPE
	LOCAL bmi:BITMAPINFO
	
    INVOKE CoCreateInstance,addr CLSID_FilterGraph,NULL,CLSCTX_INPROC,ADDR IID_IGraphBuilder,ADDR pGraphBuilder	
	INVOKE CoCreateInstance,addr CLSID_SampleGrabber,NULL,CLSCTX_INPROC,addr IID_IBaseFilter,addr pGrabberBaseFilter
	
	coinvoke pGrabberBaseFilter,ISampleGrabber,QueryInterface,addr IID_ISampleGrabber,addr pSampleGrabber
	coinvoke pGraphBuilder,IGraphBuilder,AddFilter,pGrabberBaseFilter,L("Sample Grabber")
	
	invoke RtlZeroMemory,addr mt,sizeof AM_MEDIA_TYPE
	invoke RtlMoveMemory,addr mt.majortype,addr MEDIATYPE_Video,sizeof MEDIATYPE_Video
	invoke RtlMoveMemory,addr mt.subtype,addr MEDIASUBTYPE_RGB24,sizeof MEDIASUBTYPE_RGB24
	invoke RtlMoveMemory,addr mt.formattype,addr FORMAT_VideoInfo,sizeof FORMAT_VideoInfo
	coinvoke pSampleGrabber,ISampleGrabber,SetMediaType,addr mt
	
	coinvoke pGraphBuilder,IGraphBuilder,RenderFile,L("C:\wg_gdo_1.mpeg"),0
	coinvoke pSampleGrabber,ISampleGrabber,SetBufferSamples,TRUE
	
	coinvoke pGraphBuilder,IGraphBuilder,QueryInterface,addr IID_IVideoWindow,addr pVideoWindow
	coinvoke pVideoWindow,IVideoWindow,put_AutoShow,FALSE
	
	coinvoke pGraphBuilder,IGraphBuilder,QueryInterface,addr IID_IMediaControl,addr pControl
	coinvoke pGraphBuilder,IGraphBuilder,QueryInterface,addr IID_IMediaSeeking,addr pSeek
	coinvoke pSeek,IMediaSeeking,GetDuration,addr pDuration

	coinvoke pControl,IMediaControl,Run
	
	invoke RtlZeroMemory,addr MediaType,sizeof AM_MEDIA_TYPE
	coinvoke pSampleGrabber,ISampleGrabber,GetConnectedMediaType,addr MediaType

	invoke RtlZeroMemory,addr bmi,sizeof BITMAPINFO
	
	push esi
	push edi
	mov esi,MediaType.pbFormat
	lea edi,bmi
	mov eax,40		 ;DWORD biSize
	mov ,eax
	mov eax, ;LONG  biWidth
	mov ,eax	
	mov eax, ;LONG  biHeight
	mov ,eax
	mov ax,1
	mov ,ax	 ;WORD  biPlanes
	mov ax,24		 ;WORD  biBitCount
	mov ,ax
	mov eax,BI_RGB   ;DWORD biCompression
	mov ,eax
	mov eax, ;DWORD biSizeImage
	mov ,eax	
	pop edi
	pop esi
	
	@@:
	invoke GetDC,hWnd
	mov hDC,eax
	
	invoke CreateCompatibleDC,hDC
	mov tmpDC,eax
	
	invoke CreateDIBSection,hDC,addr bmi,DIB_PAL_COLORS,addr pBuffer,NULL,NULL
	mov hBitmap,eax
	
	invoke SelectObject,tmpDC,hBitmap
	mov hOLD,eax
	
	coinvoke pSampleGrabber,ISampleGrabber,GetCurrentBuffer,addr BitmapSize,NULL
	coinvoke pSampleGrabber,ISampleGrabber,GetCurrentBuffer,addr BitmapSize,pBuffer   

	invoke BitBlt,hDC,0,0,bmi.bmiHeader.biWidth,bmi.bmiHeader.biHeight,tmpDC,0,0,SRCCOPY
	
	invoke SelectObject,tmpDC,hOLD
	invoke DeleteObject,hBitmap
	
	invoke ReleaseDC,hWnd,tmpDC
	invoke ReleaseDC,hWnd,hDC
	
	coinvoke pSeek,IMediaSeeking,GetCurrentPosition,addr pCurrent
	
	fld pCurrent
	fcomp pDuration
	fnstsw ax
	sahf
	jb @B

	coinvoke pControl,IMediaControl,Stop
	call CleanUp
	
	
GrabVideoBitmap endp

could you share some example code scali ?
i love to see it :)

here's a updated proc
the last one had some memory leak issues...

GrabVideoBitmap proc
	
	LOCAL pBuffer,hBitmap,BitmapSize,hDC,tmpDC,hOLD:dword
	
    INVOKE CoCreateInstance,addr CLSID_FilterGraph,NULL,CLSCTX_INPROC,ADDR IID_IGraphBuilder,ADDR pGraphBuilder	
	INVOKE CoCreateInstance,addr CLSID_SampleGrabber,NULL,CLSCTX_INPROC,addr IID_IBaseFilter,addr pGrabberBaseFilter
	
	coinvoke pGrabberBaseFilter,ISampleGrabber,QueryInterface,addr IID_ISampleGrabber,addr pSampleGrabber
	coinvoke pGraphBuilder,IGraphBuilder,AddFilter,pGrabberBaseFilter,L("Sample Grabber")
	
	invoke RtlZeroMemory,addr mt,sizeof AM_MEDIA_TYPE
	invoke RtlMoveMemory,addr mt.majortype,addr MEDIATYPE_Video,sizeof MEDIATYPE_Video
	invoke RtlMoveMemory,addr mt.subtype,addr MEDIASUBTYPE_RGB24,sizeof MEDIASUBTYPE_RGB24
	invoke RtlMoveMemory,addr mt.formattype,addr FORMAT_VideoInfo,sizeof FORMAT_VideoInfo
	mov mt.cbFormat,0
	mov mt.pbFormat,NULL	
	coinvoke pSampleGrabber,ISampleGrabber,SetMediaType,addr mt
	
	coinvoke pGraphBuilder,IGraphBuilder,RenderFile,L("C:\wg_gdo_1.mpeg"),0
	coinvoke pSampleGrabber,ISampleGrabber,SetBufferSamples,TRUE
	
	coinvoke pGraphBuilder,IGraphBuilder,QueryInterface,addr IID_IVideoWindow,addr pVideoWindow
	coinvoke pVideoWindow,IVideoWindow,put_AutoShow,FALSE
	
	coinvoke pGraphBuilder,IGraphBuilder,QueryInterface,addr IID_IMediaControl,addr pControl
	coinvoke pGraphBuilder,IGraphBuilder,QueryInterface,addr IID_IMediaSeeking,addr pSeek
	coinvoke pSeek,IMediaSeeking,GetDuration,addr pDuration

	coinvoke pControl,IMediaControl,Run
	
	invoke RtlZeroMemory,addr mt,sizeof AM_MEDIA_TYPE
	coinvoke pSampleGrabber,ISampleGrabber,GetConnectedMediaType,addr mt

	invoke RtlZeroMemory,addr bmi,sizeof BITMAPINFO
	
	push esi
	push edi
	mov esi,mt.pbFormat
	lea edi,bmi
	mov eax,40		 ;DWORD biSize
	mov ,eax
	mov eax, ;LONG  biWidth
	mov ,eax	
	mov eax, ;LONG  biHeight
	mov ,eax
	mov ax,1
	mov ,ax	 ;WORD  biPlanes
	mov ax,24		 ;WORD  biBitCount
	mov ,ax
	mov eax,BI_RGB   ;DWORD biCompression
	mov ,eax
	mov eax, ;DWORD biSizeImage
	mov ,eax	
	pop edi
	pop esi
	
	invoke GetDC,hwnd 
	mov hDC,eax
	
	invoke CreateCompatibleDC,hDC
	mov tmpDC,eax
	
	@@:
	
	invoke CreateDIBSection,hDC,addr bmi,DIB_PAL_COLORS,addr pBuffer,NULL,NULL
	mov hBitmap,eax
	
	invoke SelectObject,tmpDC,hBitmap
	mov hOLD,eax
	
	coinvoke pSampleGrabber,ISampleGrabber,GetCurrentBuffer,addr BitmapSize,NULL
	coinvoke pSampleGrabber,ISampleGrabber,GetCurrentBuffer,addr BitmapSize,pBuffer   

	invoke BitBlt,hDC,0,0,bmi.bmiHeader.biWidth,bmi.bmiHeader.biHeight,tmpDC,0,0,SRCCOPY
	
	invoke SelectObject,tmpDC,hOLD
	invoke DeleteObject,hBitmap
	
	coinvoke pSeek,IMediaSeeking,GetCurrentPosition,addr pCurrent
	
	fld pCurrent
	fcomp pDuration
	fnstsw ax
	sahf
	jb @B

	coinvoke pControl,IMediaControl,Stop
	
	invoke CoTaskMemFree,mt.pbFormat
	
	invoke ReleaseDC,hwnd,tmpDC
	invoke ReleaseDC,hwnd,hDC
	
	SAFE_RELEASE pSeek
	SAFE_RELEASE pControl
	SAFE_RELEASE pVideoWindow
    SAFE_RELEASE pGrabberBaseFilter
    SAFE_RELEASE pSampleGrabber
    SAFE_RELEASE pGraphBuilder
	
	ret
	
GrabVideoBitmap endp

Well, I started out from an example I found with Ogre:
http://www.ogre3d.org/tikiwiki/DirectShow+video+in+ogre+texture&structure=Cookbook
(look a bit below for the CVDShowUtil.cpp file... It's from the old DirectShow SDK, and shows some pin connecting stuff... Very important... I guess you should try and compile this, then disassemble it, so you can fix your assembly version).

I just ripped out the Ogre code and replaced it with Direct3D stuff.
Then I refactored it all to make it fit nicely into the VJ software, but that all just overcomplicates things.
I have a separate DirectShow decoder which provides frames, and a DynamicTexture which consumes these frames... By keeping the same provider and consumer interfaces, I can easily use other frame providers, such as QuickTime. And I can also use different types of DynamicTexture... Apart from D3D9, 10, 11 I also support decoding to system memory for CPU processing... and I could also support decoding to a Cuda buffer for GPGPU processing etc.