Hi All!

About dwtoa bug...




...
pos:
[COLOR=silver];mov ecx,429496730[/COLOR]

[COLOR=red]mov ecx, 3435973837[/COLOR]

mov esi, edi

.WHILE (eax > 0)
mov ebx, eax
mul ecx

[COLOR=red]shr edx, 3[/COLOR]

mov eax, edx
lea edx, [edx * 4 + edx]
add edx, edx
...
Posted on 2002-12-11 20:11:40 by Eviloid
I would mind to have definitions from MSWsock.h in PSDK ( MS extensions )
Posted on 2002-12-26 00:37:58 by Sergo
Here's a trivial one which I experienced recently.

The "equates" for VK_ADD and VK_SUBTRACT don't work. They are listed as 6Bh and 6Dh respectively but only the 2Bh and 2Dh would work properly regardless of which "+" or "-" keys are used. And those two equates cannot be found in the windows.inc file.

Raymond

(I know, I know, it's easier to use .if wparam == "+")
Posted on 2003-01-03 20:56:52 by Raymond
HUTCH--

In my windows.inc the value DC_HASDEFID has an incorrect value. In windows.inc:

DC_HASDEFID = 534h

And it should be:

DC_HASDEFID = 534bh or 0x534b

Again, thanks for all the work and help!!!

farrier
Posted on 2003-01-12 15:56:12 by farrier
Here is a couple more...
TVN_SELCHANGEDA equ TVN_FIRST -2
SHDID_COMPUTER_SHAREDDOCS equ 20
PD_USEDEVMODECOPIESANDCOLLATE equ 40000h
Posted on 2003-01-19 16:14:42 by anon
There's probably a little typo here... (windows.inc)
OUTPUT_DEBUG_STRING_INFO STRUCT

lpDebugStringData DWORD ?
fUnicode WORD ?
nDebugStringiLength WORD ? ; <- i think it should be 'nDebugStringLength' ;)
OUTPUT_DEBUG_STRING_INFO ENDS
Posted on 2003-02-02 12:06:50 by Petroizki
Greetings great hutch--

Please have in mind that you should update the include files for the new PE+ (or 64bit Pe)
When you've done so, update the new includes somewhere for us to grab them.

Thanks in advance :grin: !!!
Posted on 2003-02-20 06:45:48 by PhotoPaul
Asking ML.EXE to generate a source listing can reproducibly (see below) lead to these error messages:


Microsoft (R) Macro Assembler Version 6.14.8444
Copyright (C) Microsoft Corp 1981-1997. All rights reserved.

Assembling: C:\masm32\pro\qpf.asm
\masm32\include\windows.inc(26860) : error A2167: unexpected literal found in expression
\masm32\include\windows.inc(26861) : error A2167: unexpected literal found in expression
\masm32\include\windows.inc(26864) : error A2167: unexpected literal found in expression
\masm32\include\windows.inc(27084) : error A2167: unexpected literal found in expression
\masm32\include\windows.inc(27085) : error A2167: unexpected literal found in expression
\masm32\include\windows.inc(27089) : error A2167: unexpected literal found in expression
\masm32\include\windows.inc(27090) : error A2167: unexpected literal found in expression
\masm32\include\windows.inc(27091) : error A2167: unexpected literal found in expression
\masm32\include\windows.inc(27092) : error A2167: unexpected literal found in expression
\masm32\include\windows.inc(27093) : error A2167: unexpected literal found in expression

I am using WINDOWS.INC 1.25e, 28 January 2003. The affected lines appear in a section called "additional structures 24th November 2002". Each of them declares some structure member as either "DWORD <>" or "FLOAT <>". The error messages disappear after replacing "DWORD <>" with "DWORD ?", and "FLOAT <>" with "FLOAT ?".

Here are the conditions of the error messages:


1) \masm32\bin\ml /c /coff "%1.asm"
2) \masm32\bin\ml /c /coff /Fl"%1" "%1.asm"
3) \masm32\bin\ml /c /coff /Fl"%1" /Sn "%1.asm"
4) \masm32\bin\ml /c /coff /Fl"%1" /Sn /Sa "%1.asm"
5) \masm32\bin\ml /c /coff /Fl"%1" /Sn /Sf "%1.asm"

Using BLDALL.BAT with command line 1) does not trigger any errors. Neither does command line 2) where a source listing is requested, or command line 3) where the source listing's symbol table is suppressed. The error messages appear however with command lines 4) and 5), where ML.EXE is asked to either maximize the listing (4) or to generate a first pass listing (5).

Admittedly, the error messages occur only under rare circumstances. On the other hand, it should be easy to avoid them completely. Hope it helps.

Regards, Frank
Posted on 2003-03-26 19:22:20 by Frank
Frank,

Thanks for the technique, nect time I need to work on WINDOWS.INC I will try it out.

Regards,

hutch@movsd.com
Posted on 2003-03-27 01:18:40 by hutch--
I found the same errors when producing a debug build for VS debuging.

But I remember that were three different type changes at multiple places. But I over-wrote the original, so I could tell what the three one is.

But here is my debug build bat file, that I had to make the changes for.

Regards, P1

@echo off

if not exist rsrc.rc goto over1
\masm32\bin\rc /v rsrc.rc
\masm32\bin\cvtres /machine:ix86 rsrc.res
:over1

if exist "%1.obj" del "%1.obj"
if exist "%1.exe" del "%1.exe"

\masm32\bin\ml /c /coff /Fl"%1.lst" /FR"%1.pdb" /Sa /Zd /Zf /Zi "%1.asm" > "%1.txt"
if errorlevel 1 goto errasm

if not exist rsrc.obj goto nores

\masm32\bin\Link /SUBSYSTEM:WINDOWS /DEBUG /DEBUGTYPE:CV /PDB:"%1" "%1.obj" rsrc.obj
if errorlevel 1 goto errlink

dir "%1.*"
goto TheEnd

:nores
\masm32\bin\Link /SUBSYSTEM:WINDOWS /DEBUG /DEBUGTYPE:CV /PDB:"%1" "%1.obj"
if errorlevel 1 goto errlink
dir "%1.*"
goto TheEnd

:errlink
echo _
echo Link error
goto TheEnd

:errasm
echo _
echo Assembly Error
goto TheEnd

:TheEnd

pause
Posted on 2003-03-27 09:03:22 by Pone
i'm not sure if this is in the latest version of MASM, but it is missing from the version i have.

LOGON32_LOGON_NETWORK equ 3
Posted on 2003-04-20 20:35:34 by jademtech
KBDINPUT

KBDINPUT is not included in the windows.inc.


Sorry, I writed without Ref.

That is , the structure of Keyboard input.
Posted on 2003-06-09 19:21:26 by seasea
LVIS_CHECKED is missing also
Posted on 2003-06-10 05:55:35 by X05
Defined:



POINTFLOAT STRUCT
x FLOAT [color=red]<>[/color]
y FLOAT [color=red]<>[/color]
POINTFLOAT ENDS

GLYPHMETRICSFLOAT STRUCT
gmfBlackBoxX FLOAT [color=red]<>[/color]
gmfBlackBoxY FLOAT [color=red]<>[/color]
gmfptGlyphOrigin POINTFLOAT <>
gmfCellIncX FLOAT [color=red]<>[/color]
gmfCellIncY FLOAT [color=red]<>[/color]
GLYPHMETRICSFLOAT ENDS


Should be:



POINTFLOAT STRUCT
x FLOAT [color=blue]?[/color]
y FLOAT [color=blue]?[/color]
POINTFLOAT ENDS

GLYPHMETRICSFLOAT STRUCT
gmfBlackBoxX FLOAT [color=blue]?[/color]
gmfBlackBoxY FLOAT [color=blue]?[/color]
gmfptGlyphOrigin POINTFLOAT <>
gmfCellIncX FLOAT [color=blue]?[/color]
gmfCellIncY FLOAT [color=blue]?[/color]
GLYPHMETRICSFLOAT ENDS



Defined:

SQL_SCROLL_FORWARD_ONLY equ 0L
SQL_SCROLL_KEYSET_DRIVEN equ (-1L)
SQL_SCROLL_DYNAMIC equ (-2L)
SQL_SCROLL_STATIC equ (-3L)

DEF_MIN_PWAGE equ 0L


Should be:

SQL_SCROLL_FORWARD_ONLY equ 0
SQL_SCROLL_KEYSET_DRIVEN equ (-1)
SQL_SCROLL_DYNAMIC equ (-2)
SQL_SCROLL_STATIC equ (-3)

DEF_MIN_PWAGE equ 0
Posted on 2003-07-14 01:57:55 by Four-F
There's a constant missing from WINDOWS.INC:

BI_BITFIELDS equ 3

It's used by CreateDIBSection, etc.
Posted on 2003-07-17 13:51:42 by QvasiModo
So I will say by this question you set yourself up as a target board , but you were brave enough to carry on with updates. I just want to say , Thank you very much for all your hard work and willingness to share. :grin:
Posted on 2003-07-21 18:53:15 by mrgone
windows version constants:


VER_SUITE_SMALLBUSINESS = 00000001H
VER_SUITE_ENTERPRISE = 00000002H
VER_SUITE_BACKOFFICE = 00000004H
VER_SUITE_COMMUNICATIONS = 00000008H
VER_SUITE_TERMINAL = 00000010H
VER_SUITE_SMALLBUSINESS_RESTRICTED = 00000020H
VER_SUITE_EMBEDDEDNT = 00000040H
VER_SUITE_DATACENTER = 00000080H
VER_SUITE_SINGLEUSERTS = 00000100H
VER_SUITE_PERSONAL = 00000200H
VER_SUITE_BLADE = 00000400H
VER_NT_WORKSTATION = 0000001
VER_NT_DOMAIN_CONTROLLER = 0000002
VER_NT_SERVER = 0000003
Posted on 2003-10-05 11:11:35 by optimus