ASM Community

The three most glaring errors:

- you are missing a parameter with your call to UpdateWindow, you need to specify an hWnd

- there is not RET at the end of your WndProc

- you never move a value into hWnd1, so when you call GetMessage there is an unknown value in there


I know that you are a newbie, but that is pretty sloppy coding. You just need to take more care, and errors like this won't happen ;) :cool:

Posted on 2002-07-15 07:01:42 by sluggy

And a 0 :)

invoke WinMain, 400000h, 0, 0, SW_SHOWDEFAULT

It's not a "bad thing" (TM). You know, we already had a discussion about that :)

Here is an example source, generated by my "FRM2ASM" tool,
wich should be something like the "minimum" Window ;)
(notice that it also centers the window :rolleyes: )

        .486

        .model flat, stdcall

        option casemap :none



        include \masm32\include\windows.inc

        include \masm32\include\user32.inc

        include \masm32\include\kernel32.inc



        includelib \masm32\lib\user32.lib

        includelib \masm32\lib\kernel32.lib



.data





		szClassName		db "Form1", 0



		wc		WNDCLASSEX <sizeof wc, CS_HREDRAW \

			        or CS_VREDRAW or CS_BYTEALIGNWINDOW, \

			        offset WndProc, 0, 0, 400000h, \

			        0, 0, COLOR_BTNFACE + 1, 0, \

			        offset szClassName, 0>



		szForm1		        db "Form1", 0



.data?

		hWnd     		dd ?

		msg		        MSG <?>



.code



  start:



      call WinMain

      invoke ExitProcess, eax



  WinMain proc

      mov wc.hIcon, 0

      invoke LoadCursor, 0, IDC_ARROW

      mov wc.hCursor, eax

      invoke RegisterClassEx, addr wc

      invoke GetSystemMetrics, SM_CXSCREEN

      mov esi,eax

      invoke GetSystemMetrics, SM_CYSCREEN

      shr esi, 1

      shr eax, 1

      sub eax, 394/2

      sub esi, 228/2



      invoke CreateWindowEx, WS_EX_TOPMOST,

                             addr szClassName,

                             addr szForm1,

                             WS_CAPTION or WS_MINIMIZEBOX or WS_SYSMENU or WS_VISIBLE,

                             esi, eax, 394, 228, 0, 0, 400000h, 0

      mov hWnd, eax

      invoke ShowWindow, hWnd, SW_SHOWNORMAL

      invoke UpdateWindow, hWnd

      mov esi, offset msg

   @@:

      invoke GetMessage, esi, 0, 0, 0

      or eax, eax

      je @F

      invoke TranslateMessage, esi

      invoke DispatchMessage, esi

      jmp @B

   @@:

      mov eax, msg.wParam

      ret

  WinMain endp



  WndProc proc hWin :DWORD,uMsg :DWORD, wParam :DWORD, lParam :DWORD



     .if uMsg == WM_CREATE



    .elseif uMsg == WM_DESTROY



        invoke PostQuitMessage, 0

        xor eax, eax

        ret



    .endif



    invoke DefWindowProc, hWin, uMsg, wParam, lParam



    ret



WndProc endp



end start

I haven?t been able to come back to the thread till now.
Thanks for the real-working minimum code, bAZiK.
And also


I know that you are a newbie, but that is pretty sloppy coding. You just need to take more
care, and errors like this won't happen

I know it?s sloppy (I wisj you coul see my bedroom...) they say that the code is usually similar to the coder... I?ll have to change a lot then... and "re-distribute" my neurons, or Learn from you wizards :)
I take it easy (and wait till next one ;) )

It's explained at the bottom of this page:
http://www.asmcommunity.net/board/misc.php?s=&action=bbcode

You can try it out in our TEST forum. :)


regards,
bAZiK