ASM Community

I used a snipplet from what NaN posted once to try and make a strlen macro, and here's what i have.

$STRLENGTH MACRO Function:REQ, arg:BYTE

	push ecx

	xor eax,eax     

	doagain:            

	mov cl,[arg+eax]

	cmp cl,0            

	je  foundlength     

	inc eax    

	jmp doagain

	foundlength:

	pop ecx

    EXITM <eax>

ENDM

When I try to build it, i get this error:

consoleex.asm(14) : error A2008: syntax error : BYTE
$STRLENGTH etc is the 14th line

Thank you, that was one issue.
But actually I forgot to put it under .code

Now that I did, I get this error:

consoleex.asm(31) : error A2008: syntax error : BYTE

line 31 being:

$LEN MACRO Function:REQ, arg:BYTE

BYTE is invalid as a qualifier of a macro parameter. Valid is :REQ or :VARARG. Dont confuse "macro" with "proc". So just remove :BYTE from your code.

japheth

Im glad im able to inspire :grin: ...

I was about to point out a bug with your label references until marsface beat me to the punch... His solution is sound, but you dont HAVE to follow this if you dont want to, as well there my be a future macro where you need 3 jmps that cant be controlled with @F and @B.

So to provide labels in a macro you must define them as LOCAL's such the compiler will know to makeup new names for them each time its inserted into code.

$STRLENGTH MACRO Function:REQ, arg:REQ

             LOCAL doagain, foundlength

	push ecx

	xor eax,eax     

	doagain:            

	mov cl,[arg+eax]

	cmp cl,0            

	je  foundlength     

	inc eax    

	jmp doagain

	foundlength:

	pop ecx

    EXITM <eax>

ENDM

This will now work for multiple occourances of this macro.

Hope it helps..

:alright:
NaN

BTW: I would be interested i seeing what your brainstroming has come up with, when your satisfied and done...

hiiii

first i would like to start with
when you write mov cl, ,or mov al and etc.. you dont need to use byte ptr becuase cl is a byte .

i dont use alot in macros(dont understand in this much either) but :look at the changes i did it will save you some speed,



$STRLENGTH MACRO Function:REQ, arg:REQ
LOCAL doagain, foundlength
push ecx
mov eax,-1

doagain: inc eax
mov cl,

or cl,cl
jnz doagain
pop ecx
EXITM <eax>
ENDM

bye

eko

p.s
maybe you should check for the lenght
while ago disease_2000 published some code in here that count the length using dword it wasnt so good ,but betov published his own version then , ididnt check it but i allmost 100% sure that his version is FAST

Exnay on the Appologies-ay!!

I didnt say yours was wrong in any which way.. I actually use the @@:/@F/@B alot.. (In macros and not). I would most likely have done it the same, seeing it can fit the nice pattern you posted.

I just wanted to teach of other solutions, thats all :) So no, your post was NOT garbage... keep up the good work!

NaN

There are built-in string macros in MASM. @InStr is one of those macros - it finds a sub-string in another string, and returns the position where is found the sub-string or zero if it fails to find it. Let us look at some examples:

temp TEXTEQU @InStr(1,<We are are the world>,<are>)
% ECHO temp ;the % because we don't want 'temp' output

Output:
04

temp TEXTEQU @InStr(5,<We are are the world>,<are>)
% ECHO temp

Output:
08

temp TEXTEQU @InStr(5,<We are are the world>,<are>)
temp TEXTEQU %temp ; look what this does!
% ECHO temp

Output:
8


Syntax: @InStr({start position},{string},{sub-string})
WARNING: the built-in @ string functions are case-sensitive!

Therefor, the macro is checking if the passed parameter has "ADDR" in it. :alright:

Last minute thought, or in this case, a quote i stumbled upon in the Masm reference today...


Enjoy MaCing Macros..

NaN