ASM Community

Hi

I just finished my mp3 editor for tag v1. Everything works ok on tag v1, but tag v2 is not in use for now. I will try to finish this too. I used MPEG info procedure from Thomas for displaying this info. Thanks again Thomas. Thanks goes to Mob and to Sloarz for helping me on memory mapped files. Of course big thank to all people on this board.

stanks

MP3 Editor.zip

stanks,

400 Bad Request
Your browser sent a request that this server could not understand.
The request line contained invalid characters following the protocol string.

It could be because of the Netscape browser I'm using. I'll try it with M$ IE in a few.

----------------------------------------
Later that same day:

Yep, doesn't like Netscape..IE grabbed it fine.

Hi donkey,

Is that what is in IPicture.asm?
I looked at your code but stopped there because that file wasn't included in your .zip


Hi stanks,

Your code works fine on WinME..I've been playing around with it all morning. Thanks for posting!

Sorry I forgot that was in there. I have no right to put that include here, it doesn't belong to me. It was something that I adapted from Ernest Murphy's ImageLib routines you can remove the following lines from the ASM file then remove the include. It just converted the JPG attached image to a bitmap handle.

Somewhere around line 1155 I think


;REMOVE THESE LINES THEN REMOVE THE IPicture.inc reference

.IF FrameType == frame_APIC && (ItemIndex == 45)
mov BitmapHandle,NULL
mov eax,FRAMESTART
add eax,11
mov edi,eax
add edi,MapFileOffset

mov eax,edi
add eax,FRAMESIZE
mov FRAMEMAX,eax

@@:
mov al,
inc edi
cmp edi,FRAMEMAX
jae SkipBitmap
cmp al,0
jne @B
inc edi
@@:
mov al,
inc edi
cmp edi,FRAMEMAX
jae SkipBitmap
cmp al,0
jne @B
invoke BitmapFromMemory,edi,FRAMESIZE
mov BitmapHandle,eax
invoke GetBitmapDimensionEx,BitmapHandle,ADDR BMPSize
invoke CopyImage,BitmapHandle,IMAGE_BITMAP,BMPSize.x,BMPSize.y,LR_COPYDELETEORG
mov BitmapHandle,eax
invoke SetBitmapDimensionEx,BitmapHandle,BMPSize.x,BMPSize.y,NULL

SkipBitmap:
invoke UnmapViewOfFile,MapFileOffset
invoke CloseHandle,hMapFile
invoke CloseHandle,hFile
mov eax,BitmapHandle
ret
.endif

As a side note this software was for personal use, for this reason I thought it was OK to use the library without permission. If I was wrong well, sorry Mr. Murphy.

Donkey

Hi

I forget to tell that mp3 editor was tested on win95 and win2k (and friends win xp) without problems. So i think that it will work ok on every windows version.

Hi donkey

Thanks for posting here your program. It's great. I will try to check (i mean understand :) ) your routines. I have some problems understanding tag header info for v2.3.0
:o

stanks

Thanks for all info donkey. I didn't check your code yet. I was trying to solve this by myself. I just uploaded new version of mp3 tag editor. Genre stuff is sorted and eveything work ok (at least i hope :) ). Tag v2.3.0 is read only (and not all frame headers, just usual ones).

stanks

MP3 Editor v1.1.0

Hi

I have uploaded new version with some bug fixes and new look. TAG v2 is still in read mode only. This is debug version too. And yes you have to double click on file to see all info.

stanks

MP3 Editor v1.2.0

I was checking my procedures and i realize that GetMP3Tag2 looks like hell :mad:, so i have to rewrite it to look better :grin:

stanks

I fix some bugs that occur under XP. I will upload new version today. This version works OK under 2k and XP.

stanks