ASM Community

SpEcIeS,

Here is the same code in C from MSDN:

WIN32_FIND_DATA FileData; 

HANDLE hSearch; 

DWORD dwAttrs; 

char szDirPath[] = "c:\; 

char szNewPath[MAX_PATH]; 

char szHome[MAX_PATH]; 

BOOL fFinished = FALSE; 



hSearch = FindFirstFile("*.*", &FileData); 

if (hSearch == INVALID_HANDLE_VALUE) 

{ 

    ErrorHandler("No files found."); 

} 

 

while (!fFinished) 

{ 

    lstrcpy(szNewPath, szDirPath); 

    lstrcat(szNewPath, FileData.cFileName); 

    if (!CopyFile(FileData.cFileName, szNewPath, FALSE))

    {

        ErrorHandler("Couldn't copy file."); 

    } 

 

    if (!FindNextFile(hSearch, &FileData)) 

    {

        if (GetLastError() == ERROR_NO_MORE_FILES) 

        { 

            MessageBox(hwnd, "No more files.", 

                "Search completed.", MB_OK); 

            fFinished = TRUE; 

        } 

        else 

        { 

            ErrorHandler("Couldn't find next file."); 

        } 

    }

} 

if (!FindClose(hSearch)) 

{ 

    ErrorHandler("Couldn't close search handle."); 

} 

I'm wondering why you translate from C in "C like ASM"
Your code will be slower because of that.

The messageboard will helps you again with Readiosys's advice:
"Personally, I never use these as if I'm writing in assembly, it is to have 100% control over my source code...
Otherwise, it is better to use a HLL language like C with high optimizing compilers."

You can read it here: http://www.asmcommunity.net/board/showthread.php?threadid=9462

Regards,
Lingo

Here is an altered version of the original Copy_Files above. Is it really any different that using .IF and .WHILE? Perhaps someone could enlighten me on this subject. <???> :confused:

Revamped Copy_Files:

;======= How to use Copy_Files PROC ===========
;Copy_Files PROTO :DWORD, :DWORD

;.data
;FilesPattern db "*.*",0
;DestinationDir db "c:\",0
;BackSlash db "\",0

;invoke Copy_Files,addr FilesPattern,addr DestinationDir
;======= Required Data In Main File =============
.data?
FHandle dd ?
hSearch dd ?
Win32FindData WIN32_FIND_DATA<>
;========================================
Copy_Files proc Pattern:DWORD, DestFolder:DWORD
LOCAL tmpbuf:BYTE

invoke FindFirstFile,Pattern,addr Win32FindData

cmp eax,INVALID_HANDLE_VALUE
je InvalidHandle

mov hSearch,eax

CheckForFiles:

cmp eax,ERROR_NO_MORE_FILES
je LeaveLoop

invoke lstrcpy,addr tmpbuf,DestFolder
invoke lstrlen,addr tmpbuf

dec eax
lea ebx, tmpbuf
mov cl, BYTE PTR

cmp cl,05ch
je BSOK

invoke lstrcat,addr tmpbuf,addr BackSlash
BSOK:

cmp Win32FindData.dwFileAttributes,FILE_ATTRIBUTE_DIRECTORY
jne NotDir

jmp Continue
NotDir:

invoke lstrcat,ADDR tmpbuf,ADDR Win32FindData.cFileName
invoke CopyFile,addr Win32FindData.cFileName, addr tmpbuf,0

Continue:
invoke FindNextFile,hSearch,addr Win32FindData
invoke GetLastError

jmp CheckForFiles

LeaveLoop:

invoke FindClose,hSearch

InvalidHandle:
ret
Copy_Files endp
;========================================

This proc is tested on Win95 and 98....:)

Thanks for the input on the win2k angle gaidar :) Perhaps someone else can contribute other information regarding OS performance. I would be very greatful.

As for the use, it is good for copying file(s) from one folder to another using filename.ext and/or wildcards while filtering out the folders.

I have not tested the speed of the proc yet, but I will be on that one soon. :grin:

Thanks for the input lingo12 ;) I will get right on the modifications.

I have applied speed testings to the last two procs, old and new, and have found that the two are really not that different. I will reapply the testing once the new optimizations are in place.

Thanks again :grin:

iblis,
It is just an asm "literate" optimization rather than a speed optimization
If we want a speed optimization we will use additional criteria,
well formulated in A.Fog's book.
From other hand, the question "Why we use unoptimized assembly rather than C/C++"
is still in suspense, because modern C/C++ compilers have optimization options,
ml.exe hasn't. (see my first reply)
So, "the bottleneck is the hardware disk IO" is not important in our case, because it
doesn't depend on us and as a programmers we must improve our programming style
rather than be lazy.

Regards,
Lingo

I am with Iblis here, get it to work first, get it as small as you can be bothered and keep it ready to use with your asm code where you need file copy.

Having it already written in C/C++/VB/Delphi etc ... is not much use to you if your main source is in asm.

With regard to the posted code, I don't see the point of memory copy in the code when the file IO API function write to a buffer and read back from a buffer. Just allocate the buffer size from the file that has been opened, write the data to it and then read it back with WriteFile() to the location on disk.

Regards,

hutch@movsd.com

Lingo12,

"I'm wondering why Power Basic isn't included"

Probably because it cannot be used in asm either. :grin:

Regards,

hutch@movsd.com

lingo12,

I finally figured out the mov , 05Ch code. It took a while to sink in :rolleyes: Here is the code change to the CopyFiles proc:

invoke lstrlen,addr tmpbuf

dec eax
cmp byte ptr ,05Ch
je BSOK

inc eax

mov byte ptr,05Ch
inc eax
mov byte ptr,0

BSOK:

Thanks again for the eye opener...:grin:

Wow, now that is nice work :)

There is a lot of excellent feedback on this code....:)

This is where I left off after lingo's reply:

CopyFiles PROTO :DWORD,:DWORD
DirExist PROTO :DWORD

data?
Win32FindData WIN32_FIND_DATA<>

CopyFiles proc Pattern:DWORD, DestFolder:DWORD
LOCAL tmpbuf:BYTE

invoke DirExist,DestFolder

invoke FindFirstFile,Pattern,addr Win32FindData
mov esi, eax
inc eax
je InvalidHandle
CheckForFiles:

cmp eax,ERROR_NO_MORE_FILES
je LeaveLoop

invoke lstrcpy,addr tmpbuf,DestFolder
invoke StrLen,addr tmpbuf

dec eax
cmp byte ptr ,05Ch
je BSOK
inc eax
mov byte ptr,05Ch
inc eax
mov byte ptr,0
BSOK:
cmp Win32FindData.dwFileAttributes,FILE_ATTRIBUTE_DIRECTORY
je Continue

invoke lstrcat,addr tmpbuf,addr Win32FindData.cFileName
invoke CopyFile,addr Win32FindData.cFileName, addr tmpbuf,0
Continue:
invoke FindNextFile,esi,addr Win32FindData
invoke GetLastError
jmp CheckForFiles

LeaveLoop:
invoke FindClose,esi
InvalidHandle:
ret
CopyFiles endp

DirExist proc DestFolder:DWORD
;If Directory does not exist then create it
LOCAL CurDir:BYTE

invoke GetCurrentDirectory,MAX_PATH,addr CurDir
invoke SetCurrentDirectory,DestFolder
test eax,eax
jne @F
invoke CreateDirectory,DestFolder,NULL
@@:
invoke SetCurrentDirectory,addr CurDir

ret
DirExist endp

How is this? :)