ASM Community

This is mainly to Japheth, but if anyone else can add more light, please speak up ;)

Japheth,

Im playing around with your COMView app, and i think I've run into a problem with it. I have a transcribed Acad.inc that works, and i used your tool to make another one for testing sake. I modified my source to addapt to your calling conventions etc., and the program works as expected.. with one flaw:

One interface "IModelSpace" for example, has many "add" methods to insert objects into this drawing 'space'.

I was calling the "AddCircle" method in particular, which from my working program required the following params:

center:VARIANT, radius:REAL8, pICircleOut:PTR INTERFACE

When compiling this phase, i got a param/proto error, which when i looked into it i realized the last "PTR INTERFACE" param was not transcribed by your program. I look around and realizes all the "Add" methods failled to include its last output. I also ran your program to see if it was listed by it, and if showed only:

AddCircle | 0x60A | dispatch, func, sdtcall | Ptr IAcadCircle | Center:VARIANT, Radius:R8 | 136

As im seeing thing, the 'rcType' Field is being Ignored for "func, stdcall" typed methods. My question is: Is this intentional? Are you expecting the return to be in EAX after the invoke?? I've never seen this before and conceptually it *could* happen, but again, its not standard practice that i am aware of?? (Please correct me if im wrong here).

As well, if this is a bug, could you advise me to where in your program it should be fixed, and recompiled..

This is still an awesome tool Japheth!
Thanx for your help,
:alright:
NaN

Im havent tracked the above mentioned problem yet, but i did come across this routine which also needs some ammending (CreateInc.asm):

;--- avoid some ASM reserved names in declarations

;--- by simply add a underscore to it



CheckReservedNames	proc uses esi pStr:ptr byte



		xor esi,esi

		invoke lstrcmpi, pStr, CStr("invoke")

		.if (eax == 0)

			inc esi

		.endif

		invoke lstrcmpi, pStr, CStr("name")

		.if (eax == 0)

			inc esi

		.endif

		invoke lstrcmpi, pStr, CStr("length")

		.if (eax == 0)

			inc esi

		.endif

[b]		invoke lstrcmpi, pStr, CStr("add")

		.if (eax == 0)

			inc esi

		.endif

		invoke lstrcmpi, pStr, CStr("offset")

		.if (eax == 0)

			inc esi

		.endif[/b]

		.if (esi)

			invoke lstrcat, pStr, CStr("_")

		.endif

		ret



CheckReservedNames	endp

I had to fix these manually, but didnt mention it... (A minor point, but since you asked ;) )

:alright:
NaN

NaN,

thanks for your improvements. :)

And you have found the right place to modify (although I worked hard to get you to absolutely wrong places). Congratulations.

I remember the problem now.

          mov eax,[esi].FUNCDESC.invkind

          mov edx,[esi].FUNCDESC.funckind

         .if ((eax == INVOKE_PROPERTYGET) && (edx == FUNC_DISPATCH))

is definitely not sufficient. I once had tried

                  movzx eax, [esi].FUNCDESC.elemdescFunc.tdesc.vt

	.if (eax != VT_VOID)

which at first glance resolves this problem. But if you look again you may realize that now all functions with a return value get this extra parameter. And for functions AddRef() and Release() this is surely wrong (Ok, you will never call AddRef via Invoke_).
Up to now I didnt find any flags in typeinfo which provides for a proper solution.
So my solution was the one which is implemented now, because it served my purposes.
Help here would be very appreciated.

Japheth

Man, i can't cleanly find a way to compile this...

Im not dumb, i do know what your doing, its just I *never* go down this road. I have to compile each object separately, and then link them all to gether. However, your doing other stuff that i dont practice, which is leaving out all lib definitions (how you make it link with out 'includelib' is i do not know...). I punched in all the ones needed, but im still getting external protos not declaired like 'Malloc'... i have Oaidl.inc inlcuded...

Ahh.. im tire of this for now... too confusing just to get a compile.

Here is the *fixed* COMView compile:

Microsoft (R) Macro Assembler Version 6.14.8444

Copyright (C) Microsoft Corp 1981-1997.  All rights reserved.



 Assembling: D:\masm32\_ACTIVE\Comview\COMView.asm

Microsoft (R) Incremental Linker Version 5.12.8078

Copyright (C) Microsoft Corp 1992-1998. All rights reserved.



COMView.obj : error LNK2001: unresolved external symbol _g_hWndSB

COMView.obj : error LNK2001: unresolved external symbol _Destroy@CInterfaceList@4

COMView.obj : error LNK2001: unresolved external symbol _Create@COptions@0

COMView.obj : error LNK2001: unresolved external symbol _Destroy@COptions@4

COMView.obj : error LNK2001: unresolved external symbol _Create@CMainDlg@0

COMView.obj : error LNK2001: unresolved external symbol _Destroy@CMainDlg@4

COMView.obj : error LNK2001: unresolved external symbol _InitGlobalCEditDlg@0

COMView.obj : error LNK2001: unresolved external symbol _DeinitGlobalCEditDlg@0

COMView.exe : fatal error LNK1120: 8 unresolved externals

_

Link error

And selecting CProcessDlg for a separate compile i get:

Microsoft (R) Macro Assembler Version 6.14.8444

Copyright (C) Microsoft Corp 1981-1997.  All rights reserved.



 Assembling: D:\masm32\_ACTIVE\Comview\CProgressDlg.asm

Microsoft (R) Incremental Linker Version 5.12.8078

Copyright (C) Microsoft Corp 1992-1998. All rights reserved.



CProgressDlg.obj : error LNK2001: unresolved external symbol _malloc@4

CProgressDlg.obj : error LNK2001: unresolved external symbol _free@4

CProgressDlg.obj : error LNK2001: unresolved external symbol _CenterWindow@4

CProgressDlg.obj : error LNK2001: unresolved external symbol _GetListView@CMainDlg@4

LINK : error LNK2001: unresolved external symbol _WinMainCRTStartup

CProgressDlg.exe : fatal error LNK1120: 5 unresolved externals

_

Link error

All other dialogs are simular (more or less).

Thanx alot, i didnt expect this (i was just venting, i dont have the program that uses make files, i learned without it and never found a need for it).

Anywho, since you have recompiled it, can you do me one more small favor and recompile it again, except modify it a bit to keep it from crashing ;)

;--- avoid some ASM reserved names in declarations

;--- by simply add a underscore to it



CheckReservedNames	proc uses esi pStr:ptr byte



		mov esi, offset ReservedNames

		mov ecx, SIZERESERVEDNAMES

		.while ecx

			push ecx

			lodsd

			invoke lstrcmpi, pStr, eax

[b]			pop ecx

			.break .if (eax == 0)[/b]

			dec ecx

		.endw

		.if (ecx)

			invoke lstrcat, pStr, CStr("_")

		.endif

		ret



CheckReservedNames	endp

You had it breaking before the pop ( :tongue: ), so i reversed it as shown above. (It crashed on the first 'add' method, but it did concatenate the underscore nicely.

Thanx again for you help...
:alright:
NaN

Im sorry, i was not trying to take shots at you.. I do appreciate the work you have done with your tool, and the work your doing now..

Thank you very much..
:alright:
NaN

And more found:

"Wait"

"Goto"

"Repeat"

"Even"

"Rept"

"Or"

"Name"

"Comment"

"Union"


:rolleyes: :rolleyes: :rolleyes: NaN :rolleyes: :rolleyes: :rolleyes:

Thanks NaN,

I'm afraid after some time it ends up having all MASM names in the "reserved" names table :) .

Japheth